DM-21166: Create DiaCalculation plugins that replicate current ap_association behavior #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr525
reviewed
Oct 10, 2019
| DataFrame representing diaSources associated with this | ||
| diaObject that are observed in the band pass ``filterName``. | ||
| filterName : `str` | ||
| Simple, string name of the filter for the flux being calculated. |
There was a problem hiding this comment.
Simple as in the string name like "g" or "r". Usually they are single characters but I don't think they have to be.
sr525
reviewed
Oct 11, 2019
| filterName : `str` | ||
| Simple name of the filter for the flux being calculated. | ||
| error : `BaseException` | ||
| Error to pass. |
There was a problem hiding this comment.
Probably helpful to mention the default value here.
There was a problem hiding this comment.
(And for all the other instances of this)
Debug unittests. Debug sigma plugin. Fix up docs
Debug MAD plugin.
Debug skew.
Debug maxSlope.
Debug linear fit. Change plugin order. Fix linting
Debug stetsonJ plugin.
Debug tot flux measurements. Add None to docs. Fix name of input column for Chi2.
morriscb
force-pushed
the
tickets/DM-21166
branch
from
f433d76
to
8d2d6b7
Compare
sr525
reviewed
Oct 12, 2019
|
|
||
| @register("ap_percentileFlux") | ||
| class PercentileDiaPsFlux(DiaObjectCalculationPlugin): | ||
| """ |
sr525
reviewed
Oct 12, 2019
| DataFrame representing diaSources associated with this | ||
| diaObject that are observed in the band pass ``filterName``. | ||
| filterName : `str` | ||
| Simple, string name of the filter for the fluxb eing calculated. |
sr525
reviewed
Oct 12, 2019
| Simple, string name of the filter for the flux being calculated. | ||
| """ | ||
| if len(filterDiaFluxes) > 0: | ||
| diaObject["{}PSFluxChi2".format(filterName)] = np.nansum( |
There was a problem hiding this comment.
This might be easier to read if it is variables in the equation.
sr525
reviewed
Oct 12, 2019
| if len(filterDiaFluxes) > 0: | ||
| pTiles = np.nanpercentile(filterDiaFluxes["psFlux"], | ||
| self.config.percentiles) | ||
| for pTile, tilePercent in zip(pTiles, self.config.precentiles): |
sr525
reviewed
Oct 12, 2019
| @@ -150,5 +231,6 @@ def fail(self, diaObject, filterName, error=None): | |||
| error : `BaseException` | |||
| Error to pass. | |||
| """ | |||
| diaObject["%sPSFluxMean" % filterName] = np.nan | |||
| diaObject["%sPSFluxMeanErr" % filterName] = np.nan | |||
| for pTile in self.config.precentiles: | |||
sr525
reviewed
Oct 12, 2019
| Starting mean value or None. | ||
| alpha : `float` | ||
| Scalar down-weighting of the fractional difference. lower->more | ||
| clipping |
There was a problem hiding this comment.
It would be helpful to include all the defaults here.
sr525
reviewed
Oct 12, 2019
| "midPointTai": times}) | ||
|
|
||
| plug = StetsonJDiaPsFlux(LinearFitDiaPsFluxConfig(), | ||
| "ap_LinearFit", |
There was a problem hiding this comment.
Should this be changed to Stetson things?
There was a problem hiding this comment.
No, the StetsonJ statistic is the only thing stored.
morriscb
force-pushed
the
tickets/DM-21166
branch
from
a65db8e
to
6a4ce74
Compare
Debug WeightedMean plugin. Address last reviewer comments.
morriscb
force-pushed
the
tickets/DM-21166
branch
from
04b2521
to
12a62c0
Compare
sr525
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.