DM-22139: AP association bug with >1000 diaSources #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Nov 8, 2019
There was a problem hiding this comment.
I've verified that this fixes the original bug. It's a little worrisome that it could be either a Int64Index or a RangeIndex, so if it was straightforward to enforce the type at an earlier step I would suggest you do that instead. However, I don't think this is worth investing very much time in, so I'm fine with it as it is.
morriscb
force-pushed
the
tickets/DM-22139
branch
from
d1200ba
to
14ad6fb
Compare
Add Int64Index to indexing check. Change test from isinstance to is None Add test for unindexed dataFrames. Debug unittests. Fix linting
morriscb
force-pushed
the
tickets/DM-22139
branch
from
5b5c8d0
to
1a6fda7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.