DM-22299: Speed up specific diaCalculation plugins using fast pandas functionality #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debug plugins
Edit skew unittest. Was originally biased skew, now unbiased.
eggls6
approved these changes
Dec 2, 2019
| diaObjects.loc[:, "{}TOTFluxSigma".format(filterName)] = \ | ||
| filterDiaSources.apply(_sigma) | ||
| filterDiaSources.totFlux.agg(np.nanstd) |
There was a problem hiding this comment.
check to see if std is nan safe and statistically unbiased / pandas function
There was a problem hiding this comment.
Checked and the pandas functions are nan-safe and unbiased. I have thus changed to using these functions directly rather than agg. Checked for any performance difference using timeit and found the run time to be nearly identical with slightly less variance per loop for the pandas builtin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.