DM-21886: Create PipelineTask driver for ap_pipe tasks that interact with the APDB #68
Conversation
Naming changes for more consitencyy Debug association unittest. Convert to pandas in test. Fix linting.
Add docstring to diaPipe. Fix bugs. Debug diaPipe. Debug unittest.
| diaSources. (`pandas.DataFrame`) | ||
| - ``n_updated_dia_objects`` : Number of previously known dia_objects | ||
| with newly associated DIASources. (`int`). | ||
| - ``new_dia_oresultsbjects`` : Newly created DiaObjects from |
There was a problem hiding this comment.
Typo in "new_dia_oresultsbjects"
| @@ -129,7 +129,7 @@ def __init__(self, **kwargs): | |||
| self.makeSubtask("forcedMeasurement", | |||
| refSchema=afwTable.SourceTable.makeMinimalSchema()) | |||
|
|
|||
| def run(self, dia_objects, expIdBits, exposure, diffim, apdb): | |||
| def run(self, dia_objects, expIdBits, exposure, diffim): | |||
| """Measure forced sources on the direct and different images, | |||
| calibrate, and store them in the Apdb. | |||
There was a problem hiding this comment.
Does this docstring need to be updated? run no longer does anything with the apdb.
| returnMaxBits=True) | ||
| inputs["ccdExposureIdBits"] = expBits | ||
|
|
||
| outputs = self.run(**inputs) |
There was a problem hiding this comment.
Couldn't you just pass ccdExposureIdBits = expBits directly, rather than packing it in inputs?
There was a problem hiding this comment.
Mostly I did this parroting what was happening in calibration.py. They do a similar operation with the same value/variable.
| Load previous DiaObjects and their DiaSource history. Calibrate the | ||
| values in the diaSourceCat. Associate new DiaSources with previous | ||
| DiaObjects. Run forced photometry at the updated DiaObject locations. | ||
| Store the results in the Apdb. |
There was a problem hiding this comment.
Please spell out Apdb here.
| import lsst.dax.apdb as daxApdb | ||
| import lsst.pex.config as pexConfig | ||
| import lsst.pipe.base as pipeBase | ||
| import lsst.pipe.base.connectionTypes as connTypes |
There was a problem hiding this comment.
Could you spell out the full connectionTypes (as is used in e.g. pipe_tasks) instead of shortening it to connTypes?
There was a problem hiding this comment.
Maybe? I saw a few pipe_tasks that used cT instead of connectionTypes thought this was a good compromise?
| make_dia_source_schema) | ||
|
|
||
| __all__ = ("DiaPipelineConfig", | ||
| "DiaPipelineTask") |
There was a problem hiding this comment.
I think you also need DiaPipelineConnections in __all__.
| ) | ||
| diffIm = connTypes.Input( | ||
| doc="Difference image on which the DiaSources were detected.", | ||
| name="deepDiff_differenceExp", |
There was a problem hiding this comment.
Please use a template instead of hardcoding the "deep". I assume the Gen 3 differencing task, like the old one, will still have multiple types of diffs.
| name="deepDiff_differenceExp", | |
| name="{coaddName}Diff_differenceExp", |
Fix linting Fixup doc strings. Add DiaPipelineConnections to __all__
Add defaultTemplates to pipeline connections.
morriscb
force-pushed
the
tickets/DM-21886
branch
from
a07baa3
to
512872c
Compare
No description provided.