DM-25040: ap_association uses physical filter in Gen 3 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the physical filter would get used if that's how it was stored in the exposure, causing plugins to generate nonstandard columns that broke the database.
kfindeisen
commented
May 22, 2020
| @@ -805,7 +805,7 @@ def get_ccd_visit_info_from_exposure(exposure): | |||
| # flux zero point error ``counts``] | |||
| values = {'ccdVisitId': visit_info.getExposureId(), | |||
| 'ccdNum': exposure.getDetector().getId(), | |||
| 'filterName': filter_obj.getName(), | |||
| 'filterName': filter_obj.getCanonicalName(), # use abstract filter | |||
There was a problem hiding this comment.
get_ccd_visit_info_from_exposure doesn't seem to be used anywhere; can it be removed?
There was a problem hiding this comment.
Yes it can. It's left over from a previous iteration of the Apdb and, as you point out, is not used anywhere.
morriscb
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that caused
MapDiaSourceTaskto sometimes report observatory-specific filters, which would then get propagated to table columns. It updates allap_associationcode to standardize filter names.