DM-25280: Adapt to new alert_packet API #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
Jun 5, 2020
| @@ -42,7 +42,9 @@ class PackageAlertsConfig(pexConfig.Config): | |||
| dtype=str, | |||
| doc="Schema definition file for the avro alerts.", | |||
| default=os.path.join(getPackageDir("alert_packet"), | |||
There was a problem hiding this comment.
I think whilst this solution fixes the immediate problem it doesn't seem to me like the right solution long term. If alert_packet is installed properly then you should be using pkg_resources to locate the schemas and if they are in a zip file you will need to get a handle to the contents and not a file itself. I guess this works because of the other fix in alert_packet where you don't us python setup.py at all but copy everything over without involving setuptools.
There was a problem hiding this comment.
I agree with all of those statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.