DM-21939: Create Gen 3 AP Pipeline #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morriscb
approved these changes
Jun 11, 2020
kfindeisen
force-pushed
the
tickets/DM-21939
branch
from
283c143
to
df6a0fc
Compare
This commmit adds the {fakesType} template (though it's unlikely to be
used in the AP pipeline) and converts the input schema to a
catalog-based format.
The internal code used a different naming convention from the connections declaration, and the storage class was missing.
kfindeisen
force-pushed
the
tickets/DM-21939
branch
from
df6a0fc
to
7b50a75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
DiaPipelineTask's inputs to matchImageDifferenceTask's outputs, as modified by lsst/pipe_tasks#390. The most substantial change is having it take its input "schema" as a catalog, as this is how schemas are persisted by the Butler.