DM-11155: Implement object count metrics #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Dec 1, 2017
| ) | ||
|
|
||
| def _add_association_meta_data(self, match_result): |
There was a problem hiding this comment.
Is this metadata used anywhere, or is it for future development?
There was a problem hiding this comment.
It's used in ap_verify. This is a stop gap until the data products AssocationTask produces better routed through the Butler or similar system.
match method now returns a struct containing the updated ids and numbers summarizing the number of new, updated, and unassoicated DIAObjects. Changes to association.py and test_dia_collection.py to reflect this change in output. Editted doc string in assoc_db_sqlite.py.
Changed to reflect new return of the match method on DIACollection.
_add_association_meta_data now properly retrieves all data properly.
Changed np.concatenate to an extended list.
morriscb
force-pushed
the
tickets/DM-11155
branch
from
ee0e4a5
to
0cd575b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.