Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use iat accessor for pandas 1.1.0 compatibility #96

Merged
merged 1 commit into from Aug 4, 2020
Merged

Use iat accessor for pandas 1.1.0 compatibility #96

merged 1 commit into from Aug 4, 2020

Conversation

brianv0
Copy link
Contributor

@brianv0 brianv0 commented Jul 31, 2020 •
edited

Pandas 1.1.0 now throws a KeyError in parts of the code. The fix is to use the iat accessor.

@brianv0
Copy link
Contributor Author

brianv0 commented Jul 31, 2020

This builds passes jenkins for 1.1.0 as well as 1.0.3 environments.

@brianv0 brianv0 requested a review from morriscb July 31, 2020 18:25
morriscb
morriscb approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@morriscb morriscb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Glad it was a simple fix.

@brianv0 brianv0 merged commit 5bbf0b2 into master Aug 4, 2020
@brianv0 brianv0 deleted the tickets/DM-26148 branch August 4, 2020 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morriscb morriscb morriscb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brianv0 @morriscb