DM-31063: Copy configs from obs_* packages to ap_pipe #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
reviewed
Apr 25, 2022
…py, and dependencies.
kfindeisen
force-pushed
the
tickets/DM-31063
branch
from
3e1a020
to
dfaf24f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the AP pipelines from using local config files rather than the ones in
obs_subaru,obs_decam, andobs_lsst. This change will allow the AP configs to diverge from the DRP ones, though determining the best settings for AP is outside the scope of this work.To make it easier in the future to test for unintentional divergence from the obs packages, the configurations have all been left in Python config files, with no effort made to integrate settings into the pipelines.
In the case of ImSim, some of the AP configs combine pairs of "LSST" and "ImSim" files into a single config file. The sections originating from either config are clearly marked.