Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-34801: fix typo in fakes pipeline #117

Merged
merged 1 commit into from Jul 6, 2022
Merged

Conversation

parejkoj
Copy link
Contributor

@parejkoj parejkoj commented Jul 6, 2022

This fixes a bug I introduced in DM-34801.

@parejkoj parejkoj requested a review from ktlim July 6, 2022 21:50
Copy link
Contributor

@ktlim ktlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ktlim
Copy link
Contributor

ktlim commented Jul 6, 2022

Except that I think this is also needed in https://github.com/lsst/ap_pipe/blob/main/pipelines/ApPipe.yaml#L68 ?

@parejkoj
Copy link
Contributor Author

parejkoj commented Jul 6, 2022

Thanks for that other suggestion. I don't know how these didn't fail in pre-merge runs of ap_verify.

@parejkoj parejkoj merged commit d790a70 into main Jul 6, 2022
@parejkoj parejkoj deleted the tickets/DM-34801-fix branch July 6, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants