DM-34711: Reprocess HSC Cosmos dataset with Fakes #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kherner
approved these changes
Jul 30, 2022
This fixes a refObjLoader error from when processCcdWithFakes calls calibrateTask.
mrawls
force-pushed
the
tickets/DM-34711
branch
from
544a546
to
f71ef27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some HSC configs that caused an error when running ApPipeWithFakes. The task injects fakes to visits is sneaky because it calls calibrateTask a second time with most things (like astrometry and photometry) turned off. The PR also adds a config file for DECam so its visit-level fakes injection properly picks up camera-specific calibrateTask configs too.