DM-35207: Reset MakeWarp visitSummary connection in ApTemplate.yaml #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please put a comment line above your addition to explain why it's there? I was trying to figure it out from the PR description and commit description, but even those took me a bit. Someone looking at the pipeline will probably wonder why this isn't part of the default pipeline. |
laurenam
approved these changes
Jan 11, 2023
kfindeisen
reviewed
Jan 11, 2023
Running updateVisitSummary here (as is done in DRP) would be wasteful, as there are no updated calibration objects being produced in this pipeline.
makeCoaddTempExp is deprecated. Co-authored-by: Krzysztof Findeisen <kfindeisen@users.noreply.github.com>
TallJimbo
force-pushed
the
tickets/DM-35207
branch
from
06edda6
to
c59c429
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running updateVisitSummary here (as is done in DRP) would be wasteful, as there are no updated calibration objects being produced in this pipeline.