Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-37599: Restore calexpType template usage. #128

Merged
merged 1 commit into from Jan 12, 2023
Merged

DM-37599: Restore calexpType template usage. #128

merged 1 commit into from Jan 12, 2023

Conversation

TallJimbo
Copy link
Member

No description provided.

@TallJimbo
Restore calexpType template usage.
c7d559b 
A review comment on a similar piece of pipeline code in ap_verify
should have also been applied here on DM-35207, but I didn't notice
the similarity at the time.
kfindeisen
kfindeisen approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's one place where we don't have to consider fakes, it's ApTemplate... but I suppose it doesn't hurt.

@TallJimbo TallJimbo merged commit c9965b8 into main Jan 12, 2023
@TallJimbo TallJimbo deleted the tickets/DM-37559 branch January 12, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfindeisen kfindeisen kfindeisen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TallJimbo @kfindeisen