DM-12938: ap_pipe crashes if --output is absolute path #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good overall. However, a short explanation of what oldDir is an why it's there may be in order. Esspecially the plan is at some point to remove it. |
morriscb
approved these changes
Feb 6, 2018
python/lsst/ap/pipe/ap_pipe.py
Outdated
| @@ -440,6 +440,10 @@ def defectIngest(repo, calib_repo, defectfiles): | |||
| - They will be added to the calib registry, but not linked like the flats and biases | |||
| ''' | |||
| log = lsst.log.Log.getLogger('ap.pipe.defectIngest') | |||
| absRepo = os.path.abspath(repo) | |||
| defect_tarball = os.path.abspath(defectfiles[0] + '.tar.gz') | |||
| oldDir = os.path.abspath(os.getcwd()) | |||
There was a problem hiding this comment.
Why the name oldDir? This makes it sound like it will be removed later. Maybe add a comment here explaining this directory and it's relation to the absRepo path.
There was a problem hiding this comment.
"Old" as in "before mucking around with chdir." Would "startDir" be better?
The previous code required that ap_pipe's output repo be a relative path to an immediate subdirectory of the user's working directory, which caused crashes when an unaware user provided a different path.
kfindeisen
force-pushed
the
tickets/DM-12938
branch
from
e98252c
to
eed5396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code required that ap_pipe's output repo be a relative path to an immediate subdirectory of the user's working directory, which caused crashes when an unaware user provided a different path.