DM-13451: Make ap_verify responsible for ingestion #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-13451
branch
from
02fea5f
to
9eb34fa
Compare
mrawls
approved these changes
Feb 9, 2018
python/lsst/ap/pipe/ap_pipe.py
Outdated
| @@ -196,373 +99,66 @@ def parsePipelineArgs(): | |||
| # Parse command line arguments with argparse | |||
| parser = argparse.ArgumentParser(formatter_class=argparse.RawTextHelpFormatter, | |||
| description=textwrap.dedent(''' | |||
| Process raw decam images with MasterCals from ingestion --> difference imaging | |||
| Process raw decam images with MasterCals from basic reduction --> difference imaging | |||
There was a problem hiding this comment.
Keep this consistent with what the very first docstring says: "from basic processing --> source association"
ap_pipe no longer performs ingestion when run as a standalone program. The -d command-line argument has been replaced with a CmdLineTask-style input argument.
ap_verify now creates a repository containing templates inside it, to better simulate the production system. ap_pipe retains the ability to add templates to a repository, in order to support input repositories that don't have them.
kfindeisen
force-pushed
the
tickets/DM-13451
branch
from
9eb34fa
to
f506638
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the ingestion code from
ap_pipe(except for template "ingestion", which is kept as a workaround for DM-11865) and modifies the command-line interface ofap_pipeto accept a repository in the format matching the previous code's output. The default behavior when no template is provided has changed from assuming a specific visit ID to assuming templates are provided by the input repository.Due to API changes, must be merged simultaneously with lsst/ap_verify#20.