DM-39681: Add LATISS pipelines to ap_pipe to be used by prompt processing #142
Conversation
There was a problem hiding this comment.
I'm a bit surprised that you could get the pipeline to run with only default configs, but I see that DRP doesn't have any LATISS-specific configs, either. Just a few comments about keeping the pipeline in this package as generic and forward-compatible as possible.
pipelines/LATISS/ApPipe.yaml
Outdated
| include: | ||
| - isr | ||
| - characterizeImage | ||
| - calibrate | ||
| - retrieveTemplate | ||
| - subtractImages | ||
| - detectAndMeasure | ||
| - transformDiaSrcCat | ||
| - diaPipe |
There was a problem hiding this comment.
I'd recommend not enumerating these tasks -- they are subject to change, and it will surprise developers if only this pipeline breaks but the others (which only exclude) do not.
pipelines/LATISS/ApPipe.yaml
Outdated
| - transformDiaSrcCat | ||
| - diaPipe | ||
| parameters: | ||
| coaddName: deep |
There was a problem hiding this comment.
This seems an odd thing to put in the main pipeline, since the correct value of coaddName is a function of the data the pipeline is run on. Is it expected that all LATISS coadds will be deep? If not, I recommend this be moved to lsst-dm/prompt_processing#73.
hsinfang
force-pushed
the
tickets/DM-39681
branch
from
212f60d
to
835e3b1
Compare
No description provided.