DM-36477: Remove ap_verify_hits2015 dataset #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rai-harshit
approved these changes
Jul 18, 2023
|
Rebasing yes, squashing no. Which pair/set of commits do you consider to be a single logical change that has been incorrectly split up? |
kfindeisen
force-pushed
the
tickets/DM-36477
branch
from
18cbd67
to
2e37a81
Compare
The invalid formatting was causing the example config file to not display at all.
The default ApPipe coadds have been goodSeeing since at least June 2021 (#80).
The previous text evaluated as "The dataset framework format", which made it sound more broadly applicable than it really is.
The example used very old methods of configuring pipelines (predating the convention of instrument-specific pipelines), and requires reconfiguration to correct for drift between the ap_verify datasets and the pipeline defaults. It also read and wrote the APDB from two different locations, so the example wouldn't have worked even two years ago.
The current Science Pipelines styling restricts code blocks to 80 characters (with auto-scroll overflow), so wrapping ensures that the entire example can be seen at once.
The old links became obsolete when CmdLineTask was retired; the new links point to the pipetask docs.
The ap_verify_hits2015 dataset is obsolete and will no longer be maintained. I've updated the example data IDs to ones that are present in the smaller dataset.
kfindeisen
force-pushed
the
tickets/DM-36477
branch
from
2e37a81
to
4e337fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a large number of build problems and outdated information in the
ap_pipedocumentation, then updates the tutorial to useap_verify_ci_hits2015instead of the obsoleteap_verify_hits2015.