DM-39796: Update task config defaults to LSST values #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
This looks self-consistent as best I can tell. It would be nice if the commits were more descriptive (e.g., "this is set in pipe_tasks instead") and/or squashed into one big "Remove now-defaulted overrides" commit with the relevant descriptions bundled together there.
parejkoj
force-pushed
the
tickets/DM-39796
branch
3 times, most recently
from
aa768b4
to
0d5c0ec
Compare
These background overrides were already the default.
This commit is not intended to change pipeline behavior: the combined effect of this branch across all packages is to cleanup our configs so that the task defaults are what we believe to be most appropriate for most cases.
astrometry and photometry were already required in CalibrateTask
parejkoj
force-pushed
the
tickets/DM-39796
branch
from
0d5c0ec
to
2032646
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.