DM-41838: Update maxScaledSizeScatter thresholds for LSSTCam-imSim #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes were motivated by the psfex -> piff change for final PSF modeling in single frame measurement and the overhauled definition of the scaled size scatter metric.
kfindeisen
reviewed
Nov 27, 2023
There was a problem hiding this comment.
Thanks for keeping this in sync with obs_lsst! Hopefully DM-31047 will get done one of these days...
As for testing, this file is only used by LsstCamImSim/ApTemplate.yaml, so the only way to test it would be to manually make some coadds.
|
Just to make sure. Do you approve merging this branch? (The PR has not been officially approved...) |
|
I don't see any AP-specific problems, but I'm not qualified to comment on the numbers. So "cautious yes"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.