New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-38096: Update BPS docs for USDF. #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few clarification comments.
doc/lsst.ap.pipe/apdb.rst
Outdated
@@ -64,7 +71,15 @@ Databases can also be set up using :ref:`config files <command-line-config-howto | |||
|
|||
make_apdb.py -C myApdbConfig.py | |||
pipetask run -p ApPipe.yaml -C myApPipeConfig.py -b repo -o myrun | |||
|
|||
A Postgres database can be set up using :ref:`bps yaml files <creating-a-yaml-file>` by adding this to their yaml: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you clarify what you mean by by adding this to their yaml file
? It's not clear what their
is in this context if you just glance at this sentence.
# Memory allocated for each quantum, in MBs | ||
+Walltime: 7200 | ||
|
||
# Memory allocated for each quantum, in MBs; 2048 is default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if the comma is needed but I do see that it is that way in the prior example.
doc/lsst.ap.pipe/pipeline-bps.rst
Outdated
# CPUs to use per quantum; 1 is default. | ||
requestCpus: 1 | ||
|
||
# Arguments you would pass to pipetask run if running from the command line instead of in a bps job. | ||
# Further arguments are given in the calls to 'runQuantumCommand' (see below). | ||
# The submit YAML must specify the following arguments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is submit YAML
the name of the yaml file, or should it be submitted YAML
? Also, maybe add a : at the end of the sentence?
e0960ba
to
3107dc2
Compare
No description provided.