DM-43414: Update make_apdb module for changes in APDB API #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`make_apdb` will be replaced by `apdb-cli` sub-command, for now we keep it for compatibility reasons, but update it for new APDB API. This script depends on using pex_config for Apdb configuration, that will be replaced eventually with something different, we may want to drop this script before that change.
andy-slac
force-pushed
the
tickets/DM-43414
branch
from
15baeec
to
9b11acb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
kfindeisen
requested changes
Mar 30, 2024
There was a problem hiding this comment.
I recommend emitting a deprecation warning from make_apdb.py, otherwise people will keep using it indefinitely.
On that note, please update the docs with the recommended idioms:
- doc/lsst.ap/pipe/pipeline-tutorial.rst
- doc/lsst.ap/pipe/apdb.rst
- The comments at the top of pipelines/*/ApPipe*.yaml
- https://github.com/lsst-dm/prompt_processing/blob/main/doc/playbook.rst#databases
andy-slac
force-pushed
the
tickets/DM-43414
branch
from
a3faf0e
to
bf53ea9
Compare
|
@kfindeisen, I added deprecation, updated docs and pipelines. PR for prompt_processing playbook is here: lsst-dm/prompt_processing#151 |
kfindeisen
approved these changes
Apr 2, 2024
andy-slac
force-pushed
the
tickets/DM-43414
branch
from
bf53ea9
to
6187171
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_apdbwill be replaced byapdb-clisub-command, for now we keep it for compatibility reasons, but update it for new APDB API. This script depends on using pex_config for Apdb configuration, that will be replaced eventually with something different, we may want to drop this script before that change.