DM-14494: selectImages.py depends on defunct lsst.geom #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsst.geom no longer exists; the replacement for convexHull is sphgeom.ConvexPolygon.convexHull.
mrawls
approved these changes
May 17, 2018
| We use "convexHull" instead of generating a SphericalConvexPolygon | ||
| directly because the standard for the inputs to SphericalConvexPolygon | ||
| are pretty high and we don't want to be responsible for reaching them. | ||
| If "convexHull" is found to be too slow, we can revise this. |
There was a problem hiding this comment.
I don't entirely understand the context for this original comment, but given that the entirety of selectImages.py will be removed as part of DM-11953, I'm not overly concerned about it.
There was a problem hiding this comment.
lsst.geom had a "with input checks" and a "without checks" way to get a convex polygon. lsst.sphgeom always checks, as far as I can tell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an
ImportErrorinselectImages.pythat propagates to imports oflsst.ap.pipe. The__init__file forap.pipemay also be edited as part of this PR, but I'm waiting for confirmation from @ebellm that it's safe to do so.