DM-14497: ap_pipe doesn't know filters for AssociationTask #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morriscb
approved these changes
May 18, 2018
| @@ -99,9 +99,17 @@ def setDefaults(self): | |||
| self.differencer.doSelectSources = False | |||
|
|
|||
| self.associator.level1_db.retarget(AssociationDBSqliteTask) | |||
| # TODO: generalize in DM-12315 | |||
| self.associator.level1_db.filter_names = ['u', 'g', 'r', 'i', 'z', 'y', 'VR', 'N964'] | |||
There was a problem hiding this comment.
Why doesn't using a configfile for in the CmdLineTask work here? This looks very similar to how it would happen in such a file. I'm worried that this may be adding in values specific to DECam.
There was a problem hiding this comment.
Almost everything in the current default config is DECam-specific; DM-12315 will fix that (see also the Jira description of DM-14497).
python/lsst/ap/pipe/ap_pipe.py
Outdated
| try: | ||
| catalog = sensorRef.get(diffType + "Diff_diaSrc") | ||
| # TODO: workaround for DM-14507 |
There was a problem hiding this comment.
Now that we've found the bug in ap_association that was causing this do you want to wait for me to merge that ticket or do this for now and then remove it later?
There was a problem hiding this comment.
This is not fixed in DM-14517. Thanks for the help.
kfindeisen
force-pushed
the
tickets/DM-14497
branch
from
e4ab853
to
acbe323
Compare
Currently I only include preconditions for AssociationTask; ImageDifferenceTask's requirements are pretty unclear.
kfindeisen
force-pushed
the
tickets/DM-14497
branch
from
acbe323
to
8482e38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
ApPipeConfigto account for API changes inAssociationTask. It alsoadds a temporary workaround for DM-14507 (though I'm not sure why it works, sinceimproves the input validation ofAssociationTaskdoes the same thing internally) andApPipeConfig.