Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-14273: Add ap_verify to lsst_distrib #31

Merged
merged 6 commits into from Oct 3, 2018
Merged

Conversation

kfindeisen
Copy link
Member

This PR makes various package cleanups to conform to DM standards, and updates the documentation to assume ap_pipe is available from lsst_apps.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the table file.

ups/ap_pipe.table Show resolved Hide resolved
is a prerequisite for `lsst.ap.pipe` and is also not currently part of the
LSST Stack. You must clone ``ap_association`` and set it up first.
`lsst.ap.pipe` is available from the `LSST Science Pipelines <https://pipelines.lsst.io/>`_.
It is installed as part of the ``lsst_apps`` and ``lsst_distrib`` metapackages.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's being added to lsst_apps, not really lsst_distrib whereas this sentence implies it's part of both (distrib installs apps which happens to include ap_pipe).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it is part of both, and deliberately so.

I deliberately worded it this way because the installation instructions are geared towards ap_pipe's current user base, who are not necessarily familiar with the Stack. It would not be obvious to them that installing lsst_distrib gets you everything in lsst_apps, and in practice current users will want to install lsst_distrib anyway for the obs packages.

@kfindeisen kfindeisen merged commit 15423ad into master Oct 3, 2018
@kfindeisen kfindeisen deleted the tickets/DM-14273 branch October 3, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants