DM-16606: ap_pipe should not create DB automatically #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
changed the title
andy-slac
approved these changes
Mar 14, 2019
| @@ -161,7 +163,7 @@ A full command looks like | |||
|
|
|||
| .. prompt:: bash | |||
|
|
|||
| ap_pipe.py repo --calib repo/calibs --rerun processed -C $AP_PIPE_DIR/config/calexpTemplates.py -c associator.level1_db.db_name=ppdb/association.db --id visit=123456 ccdnum=42 filter=g --template /path/to/calexp/templates --templateId visit=234567 | |||
| ap_pipe.py repo --calib repo/calibs --rerun processed -C $AP_PIPE_DIR/config/calexpTemplates.py -c ppdb.isolation_level=READ_UNCOMMITTED -c ppdb.db_url="sqlite:///ppdb/association.db" --id visit=123456 ccdnum=42 filter=g --template /path/to/calexp/templates --templateId visit=234567 | |||
There was a problem hiding this comment.
General comment - it would be nice to get rid of tat nuisance parameter ppdb.isolation_level=READ_UNCOMMITTED and have more standard defaults in configuration. Maybe not now, but something for the new ticket.
kfindeisen
force-pushed
the
tickets/DM-16606
branch
from
5084f40
to
5894ec6
Compare
This is a breaking change to the command-line interface.
kfindeisen
force-pushed
the
tickets/DM-16606
branch
from
5894ec6
to
064edbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a
make_ppdb.pyscript that takes the same config arguments asap_pipe.pyand only callsPpdb.makeSchema, then removes the corresponding call fromApPipeTask*. This gives users more control over database creation and avoids certain race conditions whenApPipeTaskis run in parallel.*For backward-compatibility, the call from
ApPipeTaskmay be reinstated and scheduled for removal on another ticket. See discussion on#dm-alert-prod.