DM-26553: Create gen3 unittests and test CreateApFakes pipeline tasks on data. #59
Conversation
Debug quantum unittest. Debug unittests. fix up linting.
tests/test_createApFakes.py
Outdated
| # Actual input dataset omitted for simplicity | ||
| run.assert_called_once() |
There was a problem hiding this comment.
I skipped this in the example because it would have added a lot of distracting boilerplate, but since you have self.simpleMap and the tract ID, you should be able to predict the inputs to run and call assert_called_once_with.
tests/test_createApFakes.py
Outdated
| # Smoke test that the full pipeline task actualy runs. | ||
| testUtils.runTestQuantum(fakesTask, butler, quantum, False) | ||
| shutil.rmtree(root, ignore_errors=True) | ||
|
|
There was a problem hiding this comment.
Seems redundant with testRun, but ok...
There was a problem hiding this comment.
I think I can remove this since my concern here was that the values in runQuantum weren't being extracted properly. The assert_called_once_with resolves this I think.
|
Actually, I do have one question that's outside the scope of the review: it looks like |
|
There is some specificity here in the sense of the split between calexp and coadd source creation. The idea being they will show up in the diffIm differently. This config can be set up to pull all sources into both or you could just ignore the columns when running the insert tasks. I'm happy to leave this here for now and move it later. If @yalsayyad or @sr525 want, I can create a ticket to move this task into pipe_tasks so it can be used more generally down the road. I did code it as a kind of simple template class for creating fakes so it shouldn't be too hard to move it in the future. |
Debug assert_called_with_once
morriscb
force-pushed
the
tickets/DM-26553
branch
from
7f720a4
to
6f6a268
Compare
No description provided.