DM-22663: Reimplement make_apdb.py for Gen 3 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
reviewed
Oct 31, 2020
kfindeisen
force-pushed
the
tickets/DM-22663
branch
from
c8f6f0a
to
903328e
Compare
kfindeisen
force-pushed
the
tickets/DM-22663
branch
from
903328e
to
cc33cec
Compare
mrawls
approved these changes
Nov 3, 2020
The previous parser used the CmdLineTask code, but the latter will be going away when Gen 2 is removed.
The switch from ApPipeConfig to ApdbConfig is a breaking change, but one that was agreed to by the users.
This is likely to be a very common user error during the transition to Gen 3.
kfindeisen
force-pushed
the
tickets/DM-22663
branch
from
cc33cec
to
c43f447
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
make_apdb.pyscript's dependence onpipe_baseand onApPipeConfig, making it forward-compatible with Gen 3. As a side effect, the script now loads configs at a lower level, requiring changes to calling scripts.