DM-26592: Create “afterburner” to analyse the results of AP processing with fakes included #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please combine the commits into one - I don't think that there are logical blocks here that need to be kept in separate commits. |
kgabor
approved these changes
Nov 25, 2020
kgabor
approved these changes
Nov 25, 2020
| @@ -156,7 +176,19 @@ def trim(row): | |||
| return fakeCat[fakeCat.apply(trim, axis=1)] | |||
|
|
|||
There was a problem hiding this comment.
I think adding "@staticmethod" here would make it clearer that this is a standalone internal calculation.
There was a problem hiding this comment.
Eh, I'm fine with it the way it is. Not sure we use similar decorators much anywhere.
There was a problem hiding this comment.
Added a leading underscore to their names.
Debug match fakes task. Fix linting.
Debug all unittest but runQuantum. Debug most of matchFakes unittest. Add data input to butler in test. Finish debugging unittests.
Debug linting.
morriscb
force-pushed
the
tickets/DM-26592
branch
from
613f31c
to
ea17837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.