DM-28107: Convert/ingest PS1 and Gaia refcats into gen3 repo for DECam use #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
reviewed
Jan 13, 2021
| @@ -0,0 +1,67 @@ | |||
| description: The AP template building pipeline specialized for DECam | |||
There was a problem hiding this comment.
Period at end of sentence?
Is this designed for a specific dataset? If so, would be worth mentioning that here.
There was a problem hiding this comment.
It's not designed for a specific dataset, it should work for anything DECam. It should be easy to adapt for other cameras, some of the configs (like isr.doDark!) may need to change.
| doDefect: True | ||
| doNanMasking: True | ||
| doInterpolate: True | ||
| doDark: False |
There was a problem hiding this comment.
DECam doesn't have darks
| photoCal.match.referenceSelection.magLimit.fluxField: 'i_flux' | ||
| photoCal.match.referenceSelection.magLimit.maximum: 22.0 | ||
| astromRefObjLoader.ref_dataset_name: 'gaia' | ||
| #astromRefObjLoader.anyFilterMapsToThis: 'phot_g_mean' # not yet implemented in gen3, DM-27843 |
There was a problem hiding this comment.
Thanks for referencing this ticket.
pipelines/APTemplate.yaml
Outdated
| config: | ||
| doApplySkyCorr: False | ||
| #doApplyExternalPhotoCalib: False # not yet implemented in gen3 anyway | ||
| #doApplyExternalSkyWcs: False # not yet implemented in gen3 anyway |
There was a problem hiding this comment.
The "anyway"s here confuse me.
There was a problem hiding this comment.
We usually have these turned off when building templates, and couldn't turn them on if we wanted to, anyway.
mrawls
force-pushed
the
tickets/DM-28107
branch
from
dc65f41
to
4241a02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket adds a starter gen3 pipeline for building coadds (for use as diffim templates) from scratch.