DM-29147: Switch from using mapApData to new pipeline task and functors. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morriscb
force-pushed
the
tickets/DM-29147
branch
from
603f617
to
0916d1b
Compare
Debug ApPipe use of transformDiaSourceCat.
morriscb
force-pushed
the
tickets/DM-29147
branch
from
0916d1b
to
929ae88
Compare
parejkoj
reviewed
Apr 30, 2021
python/lsst/ap/pipe/ap_pipe.py
Outdated
| transformDiaSrcCat = pexConfig.ConfigurableField( | ||
| target=TransformDiaSourceCatalogTask, | ||
| doc="Task for converting and calibrating the AfwTable of DiaSources " | ||
| "to DataFrame for use in Association." |
There was a problem hiding this comment.
Rewording this: for "AfwTable", I think "afw SourceCatalog" would be a better name ("AfwTable" isn't a thing). And I think by "DataFrame" you mean "a Pandas DataFrame"?
tests/test_appipe.py
Outdated
| @@ -111,9 +111,11 @@ def mockPatchSubtasks(self, task): | |||
| """ | |||
| with patch.object(task, "ccdProcessor") as mockCcdProcessor, \ | |||
| patch.object(task, "differencer") as mockDifferencer, \ | |||
| patch.object(task, "transformDiaSrcCat") as mockTransForm, \ | |||
There was a problem hiding this comment.
This is strange capitalization. Shouldn't it be mockTransform (and below)?
morriscb
changed the title
Fix syntax error. Fixup minor wording problems. Fix linting.
morriscb
force-pushed
the
tickets/DM-29147
branch
from
b48c145
to
68a152d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug ApPipe use of transformDiaSourceCat.