DM-29869: remove some imageDifference options that are now in task defaults #79
Conversation
kherner
changed the title
restore doSelectSources=True for calexpTemplates.py
| # Don't have source catalogs for templates | ||
| self.differencer.doSelectSources = False |
There was a problem hiding this comment.
I think that, in the case of ap_verify, this actually belongs in our dataset configs (since whether or not we have template source catalogs is a function of how the templates were generated). @mrawls, is this reasoning correct? I noticed this got changed in the ImageDifferenceTask defaults, so I'm wondering if there's a more fundamental reason for doSelectSources = False.
There was a problem hiding this comment.
I am not immediately aware of a situation where we want to use template source catalogs in image differencing, even if they do happen to exist. I'm sure we could come up with a situation (DRP?), but changing the task default to line up with what we almost always use seems correct to me.
I like the idea of configuring this at the ap_verify dataset level when the new doSelectSources = False default is not appropriate.
No description provided.