DM-12257: Implement association step in ap_verify #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The do* functions have been split up to decouple ap_pipe implementation details (in particular, the structure of the repository) from clients. This should make it easier to make future improvements to ap_pipe without breaking client code. As an immediate benefit, the new API has fewer functions and is much more focused towards running parts or all of the AP pipeline.
ebellm
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some refactoring of the interface between
ap_pipeandap_verifyprior to the latter callingdoAssociation.The new API avoids exposing the file selector and repository structure to outside clients. The internal structure of the code had been left unchanged, so that the ability to potentially customize these aspects when running
ap_pipefrom the command line is still present.