New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-31899: Update example yamls including use of execution butler #92
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are at least a couple places that won't work with either w40 or w41 (e.g., outCollection being renamed to outputRun). I recommend having 0 command lines in the yaml and removing others that are the same as defaults that would practically never need to be changed. Definitely let me know if there are entries that have to be different than defaults (especially pipetask/butler commands). If you want me to read through it again after more changes, let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the intervening time when I forgot about this review, bps submit files have gotten WAY simpler! So, please update this accordingly - the bps_defaults.yaml
pulls in almost everything you need.
c441826
to
f2d08ad
Compare
I think I've made all of the changes now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of this looks self-consistent and correct now! I left a few suggestions for making it a notch better, but I don't need to review it again before you merge.
response to review cleanup after review
f2d08ad
to
ac2a344
Compare
No description provided.