Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-32245: Reprocess HiTS AP with fakes and an APDB #96

Merged
merged 4 commits into from Dec 17, 2021
Merged

Conversation

mrawls
Copy link
Collaborator

@mrawls mrawls commented Dec 3, 2021

No description provided.

Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The main change I'd like to see is use of pipeline parameters that are cross-compatible with the existing ap_pipe and ap_verify pipelines. It's a bit of work now, but would make things easier if we start running the new pipelines in ap_verify, try to use MultiTractFakes as a drop-in replacement for the existing Fakes, need to change dataset names (which we've already done once for *Diff_diaSrcTable), etc.

bps/bps_ApPipe.yaml Outdated Show resolved Hide resolved
bps/bps_ApPipe.yaml Show resolved Hide resolved
pipelines/LsstCamImSim/ProcessCcd.yaml Show resolved Hide resolved
bps/bps_ApPipeMultiTractFakes.yaml Outdated Show resolved Hide resolved
bps/bps_ApPipeMultiTractFakes.yaml Outdated Show resolved Hide resolved
pipelines/ApPipeMultiTractFakes.yaml Outdated Show resolved Hide resolved
# make_apdb.py -c isolation_level=READ_UNCOMMITTED
# -c db_url="sqlite:////project/user/association.db"
# (3) Run this pipeline, setting appropriate diaPipe configs
# (diaPipe configs should match the make_apdb.py configs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say "must"...

pipelines/ApPipeMultiTractFakes.yaml Show resolved Hide resolved
Comment on lines +12 to +20
imports:
- location: $AP_PIPE_DIR/pipelines/ApPipeMultiTractFakes.yaml
exclude: # These tasks frome from DECam's ApPipe.yaml instead
- processCcd
- location: $AP_PIPE_DIR/pipelines/DarkEnergyCamera/ApPipe.yaml
exclude: # These tasks come from ApPipeMultiTractFakes.yaml instead
- imageDifference
- diaPipe
- transformDiaSrcCat
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit worried about the juggling here, since getting this right requires knowledge of which tasks ApPipeMultiTractFakes overrides from ApPipe. Might it be simpler to work directly in terms of ProcessCcd.yaml instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this juggling will be resolved when we switch everything to multi-tract in the future. I don't immediately see another way to get all the right components and configs imported.

@mrawls mrawls force-pushed the tickets/DM-32245 branch 2 times, most recently from 8b3cc28 to 7c60c63 Compare December 16, 2021 03:12
@mrawls mrawls merged commit 4315bd2 into main Dec 17, 2021
@mrawls mrawls deleted the tickets/DM-32245 branch December 17, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants