Reinstate defect ingestion test.

The test was previously impossible because obs_test did not allow defect
ingestion, but _RepoStub doesn't know that.

python/lsst/ap/verify/ingestion.py

@@ -350,7 +350,7 @@ def _doIngestDefects(self, repo, calibRepo, defectTarball):
         # TODO: clean up implementation after DM-5467 resolved
         defectDir = os.path.join(calibRepo, "defects")
         with tarfile.open(defectTarball, "r") as opened:
-            if opened.getNames():
+            if opened.getnames():
                 pathlib.Path(defectDir).mkdir(parents=True, exist_ok=True)
                 opened.extractall(defectDir)
             else:

tests/test_ingestion.py

@@ -22,7 +22,9 @@
 #
 
 import os
+import shutil
 import glob
+import tempfile
 import argparse
 import unittest
 from collections import defaultdict
@@ -241,15 +243,18 @@ def setUpClass(cls):
                          ]
 
     def setUp(self):
-        # Unused by _ArgumentParserStub, but mandatory argument to _doIngest*
-        self._repo = self._calibRepo = 'foo'
+        # Mandatory argument to _doIngest*, used by _doIngestDefects to unpack tar
+        self._repo = self._calibRepo = tempfile.mkdtemp()
 
         self._task = ingestion.DatasetIngestTask(config=IngestionTestSuite.config)
         self._butler = _RepoStub()
         self._task.dataIngester.repo = self._butler
         self._task.calibIngester.repo = self._butler
         self._task.defectIngester.repo = self._butler
 
+    def tearDown(self):
+        shutil.rmtree(self._repo, ignore_errors=True)
+
     def testDataIngest(self):
         """Test that ingesting a science image adds it to a repository.
         """
@@ -280,6 +285,15 @@ def testCalibIngest(self):
             # queryMetadata does not work on calibs
         self.assertFalse(self._butler.datasetExists('flat', filter='z'))
 
+    def testDefectIngest(self):
+        """Test that ingesting defects adds them to a repository.
+        """
+        tarFile = os.path.join(IngestionTestSuite.testApVerifyData, 'defects.tar.gz')
+
+        self._task._doIngestDefects(self._repo, self._calibRepo, tarFile)
+
+        self.assertTrue(self._butler.datasetExists('defect'))
+
     def testNoFileIngest(self):
         """Test that attempts to ingest nothing raise an exception.
         """