DM-11745: Investigate wrapping external function calls in ap_verify #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docstring was most likely lost during the conversion of pipeline_driver to a class and back to a collection of functions.
The _MetricsRecovery decorator splits both the logic and the common API out of the individual task wrappers. The wrappers have been preserved in their explicit form for future flexibility.
kfindeisen
force-pushed
the
tickets/DM-11745
branch
from
6a1d5cf
to
c6afd76
Compare
ebellm
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new decorator,
_MetricsRecovery, topipeline_driverfor handling the shared metrics/job/metadata logic. Despite the discussion on DM-10779, I've opted not to replace the existing adapters with an assignment-like syntax. The reasons are twofold:ap_verify's strategy for handling measurements norap_pipe's API are finalized yet, and having explicit adapter functions will make it easier to absorb any changesap_verifymakes assumptions about how it interacts withap_pipe(for example, any metadata must be in thegetFullMetadata()format, andap_pipeis expected to internalize details like its system of sub-repositories), and being able to document those assumptions explicitly will make the code easier to maintainWe can always replace the explicit wrappers with statements like
_ingestRaws = _MetricsRecovery(apPipe.doIngest)later, once theap_*packages have stabilized.