DM-25806: Support parallel ap_verify ingestion in Gen 3 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser will hold common arguments that aren't related to I/O.
To keep parser use in same module as parser definitions, processes are now passed by main program to pipeline driver.
isullivan
approved these changes
Sep 18, 2020
tests/test_ingestion.py
Outdated
| copy = pickle.loads(stream) | ||
| self.assertEqual(self.task.getFullName(), copy.getFullName()) | ||
| self.assertEqual(self.task.log.getName(), copy.log.getName()) | ||
| # Equality for config ill-behaved; skip it |
There was a problem hiding this comment.
This is a minor nitpick, but could you rephrase this comment? "Skip it" suggests to me that code including a test for equality of the config is present and is skipped, while what is happening here is that code doesn't exist (for a good reason). Maybe something like "Do not test equality for the config because it is ill-behaved"?
There was a problem hiding this comment.
IIRC Config.__eq__ does exist, but it doesn't handle ConfigurableField very well. I probably should have filed a bug report, but was too distracted at the time.
Pickle support is needed to be able to run ingestion in parallel.
This passes the argument to all ingestion tasks that support the processes keyword.
kfindeisen
force-pushed
the
tickets/DM-25806
branch
from
2bebcb9
to
7638c16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements multiprocessing in
Gen3DatasetIngestTaskafter adding basic value support to theDatasetandWorkspaceclasses to make them more unit-test-friendly. This required some refactoring ofap_verify's command-line argument parser.