Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-26738: Rename abstract_filter to band #104

Merged
merged 2 commits into from Sep 25, 2020
Merged

DM-26738: Rename abstract_filter to band #104

merged 2 commits into from Sep 25, 2020

Conversation

timj
Copy link
Member

@timj timj commented Sep 23, 2020

Depends on lsst/daf_butler#378

kfindeisen
kfindeisen approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd forgotten about the documentation...

@TallJimbo @timj
Adapt test expectations to new imSim filter conventions.
1575ff4 
This commit would have ideally been part of DM-26138, but
ap_verify_testdata was not updated to the new filter definitions
introduced there until it was forced to by a need to regenerate the
Gen3 repo for other reasons.
@timj timj merged commit a98da80 into master Sep 25, 2020
@timj timj deleted the tickets/DM-26738 branch September 25, 2020 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

@kfindeisen kfindeisen kfindeisen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@timj @TallJimbo @kfindeisen