Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-26375: Allow databases other than SQLite when running ap_verify #113

Merged
merged 3 commits into from Nov 20, 2020
Merged

DM-26375: Allow databases other than SQLite when running ap_verify #113

merged 3 commits into from Nov 20, 2020

Conversation

kfindeisen
Copy link
Member

This PR lets users override db_url when calling ap_verify. I've tested the changes with lsst-pg-devel1 as well as custom SQLite stores.

isullivan
isullivan approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kfindeisen kfindeisen merged commit 2b23d8a into master Nov 20, 2020
@kfindeisen kfindeisen deleted the tickets/DM-26375 branch November 20, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isullivan isullivan isullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kfindeisen @isullivan