DM-27147: Revert to older skymap dataset type names in processing. #114
Conversation
| # (and collection naming convention) and this config override can be | ||
| # removed (other changes will probably be necessary as well, to reflect | ||
| # changes to the collection naming conventions). | ||
| pipelineArgs.extend(["--config", "imageDifference:connections.skyMap='{skyMapName}Coadd_skyMap'"]) |
There was a problem hiding this comment.
I think this will work, but since it doesn't depend on anything run-time, it might be cleaner to put it in pipelines/ApVerify.yaml.
There was a problem hiding this comment.
Good idea. I'll test this first since it's in hand, then switch to that and make sure it still works.
There was a problem hiding this comment.
So, I think that if I were to move the config override to the pipeline file, I'd have to duplicate the config overrides in the ap_pipe pipeline file, because a task: entry in an inherited pipeline replaces the inherited one instead of being merged with it (@natelust, can you confirm that?). That makes me lean towards leaving this here, but I'm happy to follow your lead if you happen to look again tonight.
There was a problem hiding this comment.
If the class pointed to by the label is the same in the base pipeline and the derived pipeline they are merged not replaced.
There was a problem hiding this comment.
Excellent, I'll go with to the pipeline solution, then. Thanks!
| # TODO: this config option resets the skymap dataset type to the templated | ||
| # name used by default prior to DM-27147. After RFC-471 is adopted, the | ||
| # ap_verify test data should be migrated to use the new dataset type name | ||
| # (and collection naming convention) and this config override can be | ||
| # removed (other changes will probably be necessary as well, to reflect | ||
| # changes to the collection naming conventions). |
There was a problem hiding this comment.
I suggest simplifying this to "TODO: remove after ap_verify datasets follow RFC-471 RFC-741 conventions".
TallJimbo
force-pushed
the
tickets/DM-27147
branch
from
151de47
to
4dffbb0
Compare
TallJimbo
force-pushed
the
tickets/DM-27147
branch
from
4dffbb0
to
68b0347
Compare
No description provided.