DM-26326: Remove obs dependency from ap_verify_testdata and ap_pipe_testdata #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ap_verify_testdata depends on obs_lsst, but should not have a formal dependency on it to avoid unnecessary rebuilds. This is a deliberate deviation from the ap_verify dataset spec, but can be worked around automatically in test code.
parejkoj
reviewed
Dec 3, 2020
| @@ -45,6 +45,12 @@ class DataTestCase(lsst.utils.tests.TestCase): | |||
| testDataset = 'ap_verify_testdata' | |||
| """The EUPS package name of the dataset to use for testing (`str`). | |||
| """ | |||
| obsPackage = 'obs_lsst' | |||
| """The obs package associated with ``testDataset`` (`str`). | |||
There was a problem hiding this comment.
Is this approach really necessary? I guess this is future-proofing other subpackages/tests using different data?
There was a problem hiding this comment.
Pretty much, yes. It seemed silly (and hard to document) to support multiple datasets but require them to all be obs_lsst. I don't think the subclass code will need to care either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR compensates for the removal of the
obs_lsstdependency from lsst/ap_verify_testdata#26 by adding a new dependency, and ensuring theDataTestCasebase class checks separately for the testdata and the obs package being available.