DM-27325: Can't rerun ap_verify on same repository in Gen 3 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morriscb
approved these changes
Mar 3, 2021
The name is used as a marker for collection(s) written by ap_verify, and need not be a run.
This allows rerunning of failed runs and removes some code duplication.
kfindeisen
force-pushed
the
tickets/DM-27325
branch
from
cbf3308
to
af2a017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bugs in both Gen 2 and Gen 3 that prevented
ap_verifyfrom being rerun for the same data and output workspace, so long as the previous run did not touch the APDB. Supporting multiple runs for the same database is a more challenging problem that would likely require extra checks inDiaPipelineTask.