Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-29338: Incorporate Gen 3 crosstalk in HiTS runs #129

Merged
merged 1 commit into from Jun 4, 2021
Merged

DM-29338: Incorporate Gen 3 crosstalk in HiTS runs #129

merged 1 commit into from Jun 4, 2021

Conversation

mrawls
Copy link
Contributor

@mrawls mrawls commented Jun 4, 2021

I successfully ran ap_verify on this ticket branch with the ap_verify_ci_cosmos_pdr2 dataset.

@mrawls mrawls requested a review from isullivan June 4, 2021 02:10
isullivan
isullivan approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, though I am curious why you are not using the goodSeeing templates here.

@mrawls
Copy link
Contributor Author

mrawls commented Jun 4, 2021

We could switch to using goodSeeing templates, but it would require more significant changes to modify the existing template-related data products in each ap_verify dataset. Perhaps something to consider in whatever form DM-28628 ever ends up taking.

@mrawls mrawls merged commit f93e0e0 into master Jun 4, 2021
@mrawls mrawls deleted the tickets/DM-29338 branch June 4, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isullivan isullivan isullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mrawls @isullivan