Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-26140: Centralize Gen 3 pipeline configuration info for ap_verify datasets #139

Merged
merged 10 commits into from
Oct 8, 2021
Merged

DM-26140: Centralize Gen 3 pipeline configuration info for ap_verify datasets #139

merged 10 commits into from
Oct 8, 2021

Commits on Oct 6, 2021

  1. Add subsets to fakes pipeline.

    @kfindeisen
    kfindeisen committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    9aa6a52 View commit details
    Browse the repository at this point in the history

  2. Add instrument specializations for ApVerify.yaml.

    @kfindeisen
    kfindeisen committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    d4539c4 View commit details
    Browse the repository at this point in the history

  3. Support pipelines in dataset format. 

    Like configs, pipelines are copied to the workspace directory for ease
of access and to allow reconstruction of exactly what was run.
    @kfindeisen
    kfindeisen committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    4ac259b View commit details
    Browse the repository at this point in the history

  4. Use dataset-specific pipeline by default.

    @kfindeisen
    kfindeisen committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    cf93cdd View commit details
    Browse the repository at this point in the history

  5. Remove hardcoded per-dataset config overrides from Gen 3.

    @kfindeisen
    kfindeisen committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    3950683 View commit details
    Browse the repository at this point in the history

  6. Add instrument specializations for ApVerifyWithFakes.yaml.

    @kfindeisen
    kfindeisen committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    801f904 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. Remove ApVerify pipelines using deep coadds by default. 

    The pipelines now inherit the task defaults (where technically possible),
with deep coadds being requested only by the ap_verify datasets that
use them.
    @kfindeisen
    kfindeisen committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    2460118 View commit details
    Browse the repository at this point in the history

  2. Hard-code support for DECam crosstalk. 

    This solution avoids the need to alter the ap_verify CLI or the ap_verify
dataset framework, making it relatively easy to undo the workaround once
DM-31492 is resolved.
    @kfindeisen
    kfindeisen committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    82cde94 View commit details
    Browse the repository at this point in the history

  3. Standardize pipelines on 2-space indent.

    @kfindeisen
    kfindeisen committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    a2a6135 View commit details
    Browse the repository at this point in the history

  4. Use parameters to describe fakes-based pipeline datasets.

    @kfindeisen
    kfindeisen committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    59d1a0e View commit details
    Browse the repository at this point in the history