DM-12535: Wrap ap_verify and run it over HITS dataset #14
Conversation
| @@ -153,11 +153,19 @@ def _measure_final_properties(metadata, output_dir, args, metrics_job): | |||
| metrics_job.measurements.insert(measurement) | |||
|
|
|||
|
|
|||
| def run_ap_verify(): | |||
| def run_ap_verify(cmdLine=None): | |||
There was a problem hiding this comment.
is there a standard way to do this in the stack? It seems unconventional...
There was a problem hiding this comment.
There's CmdLineTask.parseAndRun...
There was a problem hiding this comment.
Okay, part of the DM-11372 type work then.
demo_run.py
Outdated
| @@ -0,0 +1,277 @@ | |||
| # Run ap_verify on HiTS data | |||
There was a problem hiding this comment.
Make this a module docstring rather than a comment?
| """Adds the values of some measurements. | ||
|
|
||
| Extras and notes will be dictionary-merged (i.e., if multiple extras or | ||
| notes are assigned to the same key, only one will be preserved). |
There was a problem hiding this comment.
I'm not comfortable guaranteeing that, especially since, if any extras or notes differ, this behavior is undesirable no matter which one gets chosen.
|
I'm working on the assumption that a lot of the merging code will not be needed at all in the final implementation (e.g., because metrics are only computed based on the final DB state). If it is needed, then it will certainly need to be more generic (see the discussion surrounding DMTN-057). |
This script is a temporary hack around some existing limitations of ap_verify/ap_pipe. It should only be used for the specific purpose of testing the November 2017 AP milestones.
kfindeisen
force-pushed
the
tickets/DM-12535
branch
from
bcad30a
to
534c26e
Compare
This PR adds a wrapper script that calls
ap_verifyfor a specific set of visits and CCDs. The script has the data IDs hard-coded (since I couldn't see another way to extract them pre-ingestion), and has highly special-cased handling of measurement merging. Once DM-12314 is resolved, the script will be unneccessary, asap_verify/ap_pipewill be able to internally handle multiple dataIds.