DM-31801: Use lsst prefix for loggers #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
approved these changes
Nov 8, 2021
python/lsst/ap/verify/ingestion.py
Outdated
| @@ -48,6 +48,8 @@ | |||
| from lsst.pipe.tasks.ingestCalibs import IngestCalibsTask | |||
| from lsst.pipe.tasks.ingestCuratedCalibs import IngestCuratedCalibsTask | |||
|
|
|||
| _LOG = lsst.log.Log.getLogger(__name__) | |||
There was a problem hiding this comment.
Do we need this boilerplate in every module? I'm a bit suspicious of global variables...
There was a problem hiding this comment.
Where else would you put it? We use this form all the time in middleware.
Now forward lsst.log to Python logging.
|
@kfindeisen I switched it to python logging. I'm not sure what default log configuration you'd like but I use INFO and log messages to stdout. |
|
The scope of this work is to change the logger names but there is also a general requirement to switch all python code over to python logging where practical. Since I was already in the files I thought I may as well do that on this ticket. |
kfindeisen
reviewed
Nov 9, 2021
kfindeisen
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think in order to switch to python logging we'll have to add a logging.basicConfig and lsst.log forwarding in here somewhere.