Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-33150: Remove Gen 2 support from ap_verify #147

Merged
merged 7 commits into from Jan 26, 2022
Merged

DM-33150: Remove Gen 2 support from ap_verify #147

merged 7 commits into from Jan 26, 2022

Conversation

kfindeisen
Copy link
Member

This PR removes all Gen 2 code, tests, documentation, and configs from ap_verify.

@kfindeisen kfindeisen mentioned this pull request Jan 18, 2022
Merged
parejkoj
parejkoj approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a handful of comments. I'm a bit concerned that the removed tests result in lower coverage (you mention this in one of the commits): did you check coverage before/after this branch?

doc/lsst.ap.verify/datasets-creation.rst Outdated Show resolved Hide resolved
doc/lsst.ap.verify/datasets-creation.rst Outdated Show resolved Hide resolved
python/lsst/ap/verify/ap_verify.py Show resolved Hide resolved
@kfindeisen
Copy link
Member Author

did you check coverage before/after this branch?

If you mean in the fraction-of-lines sense, then no. The fact that I'm ripping out half the package would make such a comparison meaningless, I think.

The specific code that I was referring to (ap.verify.ingestion._findMatchingFiles and ap.verify.ingestion.Gen3DatasetIngestTask._copyConfigs) are both fairly low-risk, IMO. The former is basically frozen, while if the latter breaks it will be very obvious.

@kfindeisen kfindeisen merged commit a33c6b4 into main Jan 26, 2022
@kfindeisen kfindeisen deleted the tickets/DM-33150 branch January 26, 2022 18:43
@kfindeisen kfindeisen mentioned this pull request Jan 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parejkoj parejkoj parejkoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kfindeisen @parejkoj