DM-27117: Add dummy pipeline to ap_verify testing #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
approved these changes
Feb 17, 2022
|
|
||
| def runQuantum(self, butlerQC, inputRefs, outputRefs): | ||
| inputs = butlerQC.get(inputRefs) | ||
| if 'exposureIdInfo' not in inputs.keys(): |
There was a problem hiding this comment.
Double quotes for strings?
Comment on lines
+214
to
+220
| inputs['exposureIdInfo'] = obsBase.ExposureIdInfo.fromDataId( | ||
| butlerQC.quantum.dataId, "visit_detector") | ||
|
|
||
| if self.config.doAstrometry: | ||
| inputs.pop('astromRefCat') | ||
| if self.config.doPhotoCal: | ||
| inputs.pop('photoRefCat') |
There was a problem hiding this comment.
Double quotes for all string literals?
kfindeisen
force-pushed
the
tickets/DM-27117
branch
from
da855c5
to
e460982
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dummy pipeline that mirrors the form, configuration, and connections of
${AP_PIPE_DIR}/pipelines/ApPipe.yaml, but is specialized forap_verify_testdataand does no processing besides dataset handling. It then rewrites the tests intest_driver.pyto make use of the new pipeline.This change pushes the total unit test run time up to a minute (30 s per individual test), but I don't see any way to reduce this time at present. Because the repository setup for
ap_verifyis fairly complex and doesn't allow for customization hooks, creating an in-memory repository is not practical. I did try to factor the repository setup intosetUpClass, but this actually increased test run time.In any case, 20 s of each test's 30 s run time is from running the pipeline itself; this will be addressed on DM-33734 since it has implications for Production.