DM-32694: Split AP pipeline into ApPipeWithFakes #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly defining a parameter for each possible dataset was too much of a hassle, so instead I rewrote the contracts to be template-agnostic.
This change avoids a lot of the chaos associated with structural differences between the fakes and non-fakes pipelines.
mrawls
approved these changes
May 12, 2022
After this change, most of the pipeline configuation is inherited from ap_pipe.
kfindeisen
force-pushed
the
tickets/DM-32694
branch
from
0d4915f
to
629f47c
Compare
mrawls
reviewed
May 17, 2022
These files should be the source of truth for all instrument-specific configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
ApVerifyWithFakespipeline to depend onApPipeWithFakes(itself reworked on lsst/ap_pipe#106) instead ofApVerify. This change improves consistency with the "base" AP pipeline and avoids some of the contract conflicts that made the previousApVerifyWithFakesmore complicated and more brittle than it needed to be.